Fixed some problems with MOD #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w only be compiled for Debug build. Still left in there for later debugging if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that I've added more debugging code than actually fixing problems.
But hey. Maybe I still need it later on if something goes wrong again.
The problem with the strange "Value must be positive message" was fixed.
MOD samples are generated using 16 Bit BASS samples instead of 8 Bit. This fixes this strange periodic noise which was generated before.
Also the original frequency of the sample is ignored as target frequency as for ProTracker only certain base frequencies can be used.
I hope this is satisfying to you. I haven't programmed C# for about 10 years and my experiences with MOD files might be not as much as you have.
Tested with:
mono Xrns2XModShell.exe resources/examples/test_mod_sample_conversion.xrns -t mod --out test.mod