Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scala 2.12.10 #671

Merged
merged 4 commits into from
Jan 9, 2020
Merged

Update to Scala 2.12.10 #671

merged 4 commits into from
Jan 9, 2020

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Sep 12, 2019

No description provided.

@fthomas
Copy link
Owner Author

fthomas commented Jan 9, 2020

The build fails with these errors:

sbt:refined> coreJVM/mimaReportBinaryIssues
[error]  * static method refineMV()eu.timepit.refined.internal.RefineMPartiallyApplied in class eu.timepit.refined.package has a different signature in current version, where it is <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefineMPartiallyApplied<Leu/timepit/refined/api/Refined;TP;>; rather than <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefineMPartiallyApplied<Ljava/lang/Object;TP;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.package.refineMV")
[error]  * static method refineV()eu.timepit.refined.internal.RefinePartiallyApplied in class eu.timepit.refined.package has a different signature in current version, where it is <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefinePartiallyApplied<Leu/timepit/refined/api/Refined;TP;>; rather than <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefinePartiallyApplied<Ljava/lang/Object;TP;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.package.refineV")
[error]  * method refineV()eu.timepit.refined.internal.RefinePartiallyApplied in object eu.timepit.refined.package has a different signature in current version, where it is <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefinePartiallyApplied<Leu/timepit/refined/api/Refined;TP;>; rather than <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefinePartiallyApplied<Ljava/lang/Object;TP;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.package.refineV")
[error]  * method refineMV()eu.timepit.refined.internal.RefineMPartiallyApplied in object eu.timepit.refined.package has a different signature in current version, where it is <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefineMPartiallyApplied<Leu/timepit/refined/api/Refined;TP;>; rather than <P:Ljava/lang/Object;>()Leu/timepit/refined/internal/RefineMPartiallyApplied<Ljava/lang/Object;TP;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.package.refineMV")
[error]  * method this(eu.timepit.refined.api.RefinedType,shapeless.Witness)Unit in class eu.timepit.refined.types.string#FiniteString#FiniteStringOps has a different signature in current version, where it is (Leu/timepit/refined/api/RefinedType<Leu/timepit/refined/api/Refined<Ljava/lang/String;Leu/timepit/refined/collection$Size<Leu/timepit/refined/boolean$And<Leu/timepit/refined/boolean$Not<Leu/timepit/refined/numeric$Less<Lshapeless/_0;>;>;Leu/timepit/refined/boolean$Not<Leu/timepit/refined/numeric$Greater<TN;>;>;>;>;>;>;Lshapeless/Witness;)V rather than (Leu/timepit/refined/api/RefinedType<Ljava/lang/String;>;Lshapeless/Witness;)V
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.types.string#FiniteString#FiniteStringOps.this")
[error]  * method apply(eu.timepit.refined.api.RefinedType,shapeless.Witness)eu.timepit.refined.types.string#FiniteString#FiniteStringOps in object eu.timepit.refined.types.string#FiniteString has a different signature in current version, where it is <N:Ljava/lang/Object;>(Leu/timepit/refined/api/RefinedType<Leu/timepit/refined/api/Refined<Ljava/lang/String;Leu/timepit/refined/collection$Size<Leu/timepit/refined/boolean$And<Leu/timepit/refined/boolean$Not<Leu/timepit/refined/numeric$Less<Lshapeless/_0;>;>;Leu/timepit/refined/boolean$Not<Leu/timepit/refined/numeric$Greater<TN;>;>;>;>;>;>;Lshapeless/Witness;)Leu/timepit/refined/types/string$FiniteString$FiniteStringOps<TN;>; rather than <N:Ljava/lang/Object;>(Leu/timepit/refined/api/RefinedType<Ljava/lang/String;>;Lshapeless/Witness;)Leu/timepit/refined/types/string$FiniteString$FiniteStringOps<TN;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.types.string#FiniteString.apply")
[error]  * method refinedRefType()eu.timepit.refined.api.RefType in object eu.timepit.refined.api.RefType has a different signature in current version, where it is ()Leu/timepit/refined/api/RefType<Leu/timepit/refined/api/Refined;>; rather than ()Leu/timepit/refined/api/RefType<Ljava/lang/Object;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.api.RefType.refinedRefType")
[error]  * static method refinedRefType()eu.timepit.refined.api.RefType in interface eu.timepit.refined.api.RefType has a different signature in current version, where it is ()Leu/timepit/refined/api/RefType<Leu/timepit/refined/api/Refined;>; rather than ()Leu/timepit/refined/api/RefType<Ljava/lang/Object;>;
[error]    filter with: ProblemFilters.exclude[IncompatibleSignatureProblem]("eu.timepit.refined.api.RefType.refinedRefType")

We're hitting lightbend-labs/mima#423 here and it seems to me that it is okay to just ignore these problems.

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #671 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   94.22%   94.24%   +0.01%     
==========================================
  Files          62       62              
  Lines         762      764       +2     
  Branches        7        7              
==========================================
+ Hits          718      720       +2     
  Misses         44       44
Impacted Files Coverage Δ
.../scala/eu/timepit/refined/shapeless/typeable.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf159e...71c60bc. Read the comment docs.

@fthomas fthomas merged commit c345362 into master Jan 9, 2020
@fthomas fthomas deleted the update/scala-2.12.10 branch January 9, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant