New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complement SCM URL with Scaladex #837
Conversation
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 66.3% 66.79% +0.49%
==========================================
Files 87 92 +5
Lines 1279 1265 -14
Branches 29 36 +7
==========================================
- Hits 848 845 -3
+ Misses 431 420 -11
Continue to review full report at Codecov.
|
29df383
to
7ae71f2
Compare
29df383 attempted to fix "Regex DoS" issue found in Codacy quality review, but the issue remained (maybe false-positive). |
# Conflicts: # modules/core/src/main/scala/org/scalasteward/core/vcs/package.scala
I like the idea! One thing I'm wondering is if we could use Scaldex' API instead of using regexes on its HTML pages? |
I also prefer using API but could not find API client nor document. |
I've not seen an overview, but at least this endpoint exists: https://index.scala-lang.org/api/search?q=refined&target=JVM&scalaVersion=2.12 |
Oops, I wrongly deleted the branch. |
I think this would be useful even if we can't use the API. But if we add it, #941 will become more important. |
Unfortuately, number of
pom.xml
without SCM URL are not small.Therefore Scala Steward can not include URL/diff URL in PR for such artifacts.
Scaladex neatly know SCM URLs even if
pom.xml
lacks it.So let's use Scaladex as a second resource.
Original idea: #82 (comment).
This is not perferct solution since Scaladex do not index non-Scala artifacts (e.g. aws-sdk-java), but definitely improve situations !!
Notes
Only artifact id is used as search query, since the below Scaladex issues.
scalacenter/scaladex#577
scalacenter/scaladex#578
Example PRs