displaying a Google Slides doc in a carousel

[railsagainstignorance]

Georgia (et al) would like to be able to
(a) display a google slides doc without any hassles, and
(b) to include one in a carousel

[seanmtracey]

Should be fine in any Electron-powered version of Screens. Can update the carousel so that if it's in Electron, it uses WebViews instead of iframes. Webviews are already implemented for viewing content (such as YT vids and other sites that fall foul of CORs), so it should work.

[AdaRoseCannon]

Electron now uses webviews so this should be possible now, closing this issue.

[JakeChampion]

Electron Screens only uses Webviews for the main iframe. We have yet to create Electron specific carousel and layout systems.

[JakeChampion]

Could we test this out and see if it works?

[AdaRoseCannon]

@seanmtracey please can you quickly test this in an electron build if you get a sec?

[seanmtracey]

I can't confirm that the carousels work in Electron. Unsure as to why atm, but we should hold off merging any logic until we know the cause.

[JakeChampion]

There is no implementation of carousels that works with Electron's webviews instead of iframes. We did a small attempt at this to see if it was possible.

Electron can not house a webview within a webview, this means we can't replace iframes with webviews.

To get carousels working we could follow what the Chrome extension has done, which is to reimplement the viewer page and all functionality which involves iframes. We have not done this as of yet because the demand for such functionality is not high. It is definitely something we should look into however, we would then have 3 implementations of the viewer logic, I'm not sure that is a good thing. We could attempt to create a commonJS/ES6 module which houses most of the logic which the 3 viewers could inherit or extend.

[AdaRoseCannon]

I am actually agreeing with the commonJS module. I almost did when I did it for the extension but it didn't seem necessary when I didn't expect us to support 3 solutions.

Now it seems very necassary.

[AdaRoseCannon]

This will be fixed by #52