This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Viewer library #52
Merged
Viewer library #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Looks good to me. |
|
It says tests failing but, |
| const Viewer = require('ftlabs-screens-viewer'); | ||
| const Carousel = require('ftlabs-screens-carousel'); | ||
| const port = location.port ? ':'+location.port : ''; | ||
| const host = '//'+location.hostname+port; |
There was a problem hiding this comment.
I think location.origin would be a better fit.
location.origin returns the protocol, hostname and port --
"http://local.ft.com:3000"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for using the viewer module. Which interfaces with the api and handles scheduling.
Don't merge yet there are no tests written for the viewer library.This keeps the same functionality (no carousel integration) but uses the new library.Tests are added to viewer now
Added carousel too.
Need to fix screens tests now...
Fixes #11
Fixes #53