Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Added sensible default for root directory #1

Merged
merged 2 commits into from
May 29, 2014
Merged

Added sensible default for root directory #1

merged 2 commits into from
May 29, 2014

Conversation

wheresrhys
Copy link
Contributor

So it's easier to use from the cli

Ac ouple of improvements which woudl help further woudl be

  1. Ability to pass in root directory as a cli param
  2. Read the root directory from .bowerrc if present and not overridden by config

So it's easy to use from the cli
@kornelski
Copy link
Contributor

I don't see the CLI change.

Presence of root directory config changes how paths are interpreted, so you may need to change/delete code in other places: https://github.com/ftlabs/textrequireify/blob/master/index.js#L37 https://github.com/ftlabs/textrequireify/blob/master/index.js#L43

@wheresrhys
Copy link
Contributor Author

I didn't add a CLI interface, but if you pass textrequireify in as a transform when using command line browserify using -t textrequireify it currently throws an error. Setting the root directory to a sensible default prevents this (at least when the project's bower directory is ./bower_components).

I'll edit those other two lines now

kornelski added a commit that referenced this pull request May 29, 2014
Added sensible default for root directory
@kornelski kornelski merged commit 1b63fd1 into ftlabs:master May 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants