-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal error: Uncaught Error: Call to undefined method Error::shutdown_handler() #1942
Comments
Fuel v1 hasn't been tested on PHP7 yet, so I couldn't say. |
Can't use |
I know (just didn't think of it). It's something that needs to be addressed, because your fix means you can't overload the Error class anymore. |
Looks like we need to rename the |
Yes, we need to rename the |
There might be other PHP7 fixes needed. Changing this will break BC for v1 (in regards to extending the Error class), so I need a careful think about how to address this issue. We might have to use the same sort of trick we used for Redis when that became a PHP extension. |
This could simply be something we need to break to continue with php7, how many people extend the |
Already addressed, fix is on it's way ;) I just hate breaking BC if it's not needed. |
Thank you! Now only one test fails:
|
This is not an easy fix, as xml is processed by an extension using libxml, which seems to treat false values different between 5.x |
How about this? --- a/tests/format.php
+++ b/tests/format.php
@@ -125,6 +125,9 @@ line 2","Value 3"',
<xml><item><field1>Value 1</field1><field2>35</field2><field3>1</field3><field4/></item></xml>
',
'<?xml version="1.0" encoding="utf-8"?>
+<xml><item><field1>Value 1</field1><field2>35</field2><field3>1</field3><field4></field4></item></xml>
+',
+ '<?xml version="1.0" encoding="utf-8"?>
<xml><item><field1>Value 1</field1><field2>35</field2><field3>true</field3><field4>false</field4></item></xml>
',
'<?xml version="1.0" encoding="utf-8"?>
@@ -408,10 +411,18 @@ line 2","Value 3"',
* @test
* @dataProvider array_provider5
*/
- public function test_to_xml_boolean($array, $default, $true, $number)
+ public function test_to_xml_boolean($array, $default, $default_php7, $true, $number)
{
// default
- $this->assertEquals($default, Format::forge($array)->to_xml());
+ if (version_compare(PHP_VERSION, '6.99.99') > 0)
+ {
+ $this->assertEquals($default_php7, Format::forge($array)->to_xml());
+ }
+ else
+ {
+ $this->assertEquals($default, Format::forge($array)->to_xml());
+ }
+
// true/false
$this->assertEquals($true, Format::forge($array)->to_xml(null, null, null, null, true));
// 1/0 [Edited] changed compared version. |
I would prefer something like
instead. Seeing a PHP 6 version being referred to always looks funny... |
This failure has nothing related with php7. But it is because of old libxml version. |
Fatal error: Uncaught Error: Call to undefined method Error::error_handler() in /home/hostname/public_html/folder/fuel/core/bootstrap.php:48 Stack trace: #0 /home/hostname/public_html/folder/fuel/core/vendor/phpseclib/Crypt/AES.php(467): {closure}(8192, 'Function mcrypt...', '/home/hostname/...', 467, Array) #1 /home/hostname/public_html/folder/fuel/core/vendor/phpseclib/Crypt/AES.php(279): PHPSecLib\Crypt_AES->_mcryptSetup() #2 /home/hostname/public_html/folder/fuel/core/classes/crypt.php(107): PHPSecLib\Crypt_AES->encrypt('a:3:{i:0;a:6:{s...') #3 /home/hostname/public_html/folder/fuel/core/classes/session/driver.php(459): Fuel\Core\Crypt::encode('a:3:{i:0;a:6:{s...') #4 /home/hostname/public_html/folder/fuel/core/classes/session/cookie.php(111): Fuel\Core\Session_Driver->_set_cookie(Array) #5 [internal function]: Fuel\Core\Session_Cookie->write('', Array) #6 /home/hostname/public_html/folder/fuel/core/classes/event/instance.php(163): call_user_func(Array, '', Array) #7 /home/hostname/public_html/wor in /home/hostname/public_html/folder/fuel/core/bootstrap.php on line 48 |
@ji1t |
The above error was triggered in phpseclib. You have to be careful when using external components with PHP versions as ancient as 5.6. Having said that, we still have maintained apps running on 5.6, so it is not framework related, but an issue in your specific environment. What will require some debugging... |
@WanWizard |
Is this a bug of PHP or Fuel?
Fix:
The text was updated successfully, but these errors were encountered: