Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2

Closed
wants to merge 1 commit into from
Closed

Develop #2

wants to merge 1 commit into from

Conversation

jsarch
Copy link

@jsarch jsarch commented Mar 31, 2011

Rest router checks if method is callable before invoking. Returns 404 if method is not callable.

@jsarch
Copy link
Author

jsarch commented Mar 31, 2011

Example of issue:

  1. Install Fuel as documented

  2. Create test REST controller : http://fuelphp.com/docs/general/controllers/rest.html

  3. Go to: http://localhost/test/missing_method.json?foo=bar

Rather than cause an exception, I think the REST controller should return a 404 as in Request::execute(). My change above tried to follow the same approach.

@philsturgeon
Copy link
Contributor

Done slightly differently, but thank you.

WanWizard pushed a commit that referenced this pull request Aug 7, 2011
fixed typo in cache class #2
saitara added a commit to saitara/core that referenced this pull request Oct 2, 2017
A code `Input_Instance->param('size', 1)` without http PUT parameters doesn't work.

```
fuel#2 /usr/share/nginx/mandarin.io/fuel/core/classes/input/instance.php(302): array_merge(Array, Array, '', Array, Array) 
```

To fix that, make cast as array for every parameters in function all().
anstokes added a commit to anstokes/fuelphp-core that referenced this pull request Dec 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants