Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putall is missing comment and raises AttributeError #218

Closed
rene00 opened this issue Aug 30, 2018 · 1 comment · Fixed by #219
Closed

putall is missing comment and raises AttributeError #218

rene00 opened this issue Aug 30, 2018 · 1 comment · Fixed by #219

Comments

@rene00
Copy link
Contributor

rene00 commented Aug 30, 2018

$ python credstash.py --region=us-west-1 put foo bar
foo has been stored
$ python credstash.py --region=us-west-1 getall > foo.json
$ python credstash.py --region=us-west-1 putall @foo.json
Traceback (most recent call last):
  File "credstash.py", line 935, in <module>
    main()
  File "credstash.py", line 919, in main
    putAllSecretsAction(args, region, **session_params)
  File "credstash.py", line 246, in func_wrapper
    return func(*args, **kwargs)
  File "credstash.py", line 411, in putAllSecretsAction
    putSecretAction(args, region, **session_params)
  File "credstash.py", line 246, in func_wrapper
    return func(*args, **kwargs)
  File "credstash.py", line 386, in putSecretAction
    context=args.context, digest=args.digest, comment=args.comment,
AttributeError: 'Namespace' object has no attribute 'comment'
rene00 added a commit to rene00/credstash that referenced this issue Aug 30, 2018
@CaseyLabs
Copy link

Just following up on this issue, as I've just encountered it. @alex-luminal - would it be possible to have this PR for credstash merged in?

Current issue encountered:

credstash getall > secrets.json

credstash putall @secrets.json

Traceback (most recent call last):
  File "/usr/local/bin/credstash", line 11, in <module>
    sys.exit(main())
  File "/usr/local/bin/credstash.py", line 919, in main
    putAllSecretsAction(args, region, **session_params)
  File "/usr/local/bin/credstash.py", line 246, in func_wrapper
    return func(*args, **kwargs)
  File "/usr/local/bin/credstash.py", line 411, in putAllSecretsAction
    putSecretAction(args, region, **session_params)
  File "/usr/local/bin/credstash.py", line 246, in func_wrapper
    return func(*args, **kwargs)
  File "/usr/local/bin/credstash.py", line 386, in putSecretAction
    context=args.context, digest=args.digest, comment=args.comment,
AttributeError: 'Namespace' object has no attribute 'comment'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants