Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactored incorrectFeedback and correctFeedback to TrueFeedback… #63

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

livinNector
Copy link
Contributor

… and FalseFeedback respectively

This fixes #62

@fuhrmanator
Copy link
Owner

@livinNector thanks again for the PR -- I tweaked again the editor to make use of the changes. But I realize this will be a breaking change (API changes) for feedback, which means a major release if I respect NPM's semantic versioning. It's just a number, but I might want to wait for other major changes (other refactorings of the API) before merge/releasing this? What do you think?

@livinNector
Copy link
Contributor Author

Yeah, I feel that is right. Since I am trying to build the reverse parser (JSON -> GIFT), I feel that some other refactorings could also be considered. I am trying to put together a JSON schema for the parser, will add that soon, this will help us do this refactoring in a cleaner way. And having a JSON schema will be good for documentation purposes also.

@fuhrmanator fuhrmanator merged commit 7b088e2 into fuhrmanator:master Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguity and misalignment of feedback on True - False questions
3 participants