Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak (<>) import for optparse-applicative-0.13 #60

Closed
wants to merge 2 commits into from
Closed

tweak (<>) import for optparse-applicative-0.13 #60

wants to merge 2 commits into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 22, 2017

No description provided.

optparse-applicative-0.13 stopped exporting own version of (<>)
and build fails as:
  src/Hi/CommandLineOption.hs:23:39: error:
    • Variable not in scope: (<>) :: Mod f2 a2 -> Mod f1 a1 -> t0
    • Perhaps you meant one of these:
        ‘<$>’ (imported from Options.Applicative),
        ‘<*’ (imported from Options.Applicative),
        ‘<|>’ (imported from Options.Applicative)

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
I have both temporary-1.2.0.4 and temporary-rc-1.2.0.3
installed globally. doctest run does not hide anything
by default and it causes import collisions:

    Ambiguous interface for ‘System.IO.Temp’:
      it was found in multiple packages:
      temporary-1.2.0.4 temporary-rc-1.2.0.3

The change uses PackageImports language extension
to pin to "temporary" package (used in .cabal file).

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
@fujimura
Copy link
Owner

@trofi Sorry for late reply, I've just pushed 7ce431a into master, but skipped 3b774b1 because it seems to be not happening in every environment(I've experienced this once ago though). Anyway, thanks a lot for contribution!

@fujimura fujimura closed this Mar 25, 2018
@trofi
Copy link
Contributor Author

trofi commented Mar 25, 2018

temporary / temporary-rc failure happens when you have both installed in the sandbox (or globally, or as user):

$ cabal --version
cabal-install version 1.24.0.2
compiled using version 1.24.2.0 of the Cabal library

$ cabal sandbox init
$ cabal install --reinstall --force-reinstall temporary temporary-rc
...
Installed temporary-1.2.1.1
Installed temporary-rc-1.2.0.3

$ cabal test
...
Running 2 test suites...
Test suite doctests: RUNNING...

src/Hi/Directory.hs:9:1: error:
    Ambiguous interface for ‘System.IO.Temp’:
      it was found in multiple packages:
      temporary-1.2.1.1 temporary-rc-1.2.0.3

adetokunbo added a commit to adetokunbo/hi that referenced this pull request Jul 17, 2018
Since it was last tagged 1.2.0.1, this package has not had any breaking changes.
It has had one important fix (fujimura#60), but this has not been pushed to hackage.

As a consequence hi, does not build on hackage (and also on NixOS) and `cabal
install` fails.

This change adds a new minor version which includes the fix in fujimura#60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants