This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Multiline test descriptions and indentation for nested tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetlyak40wt
added a commit
to 40ants/cl-hamcrest
that referenced
this pull request
Jan 11, 2017
svetlyak40wt
force-pushed
the
multiline-indentation
branch
2 times, most recently
from
d02618e
to
8653614
Compare
svetlyak40wt
force-pushed
the
multiline-indentation
branch
from
8653614
to
d21a29f
Compare
|
@fukamachi please, review this pull. I've rebased it upon the master branch. |
Multiline test descriptions will be indented according to the test's indentation level. This can be useful if you want to provide comprehensive testcase description. This change was made to make cl-hamcrest work with Prove, as this library uses multiline description to provide detailed information about expected datastructures.
svetlyak40wt
force-pushed
the
multiline-indentation
branch
from
d21a29f
to
f5cb39d
Compare
|
Eitaro, please, review this patch 😭 |
|
Great! You are the best! 🤝 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Working on cl-hamcrest I discovered, that it is hard to make tests which have multiline descriptions in Prove. CL-HAMCREST uses them to show failed match in a structured way, to make it easy to see where is wrong data.
In this pull, I've refactored a way how text indentation works inside of Prove.