-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of resources breaks the resource view order and doesnt append scrollbars to the bottom of the view #74
Comments
could you follow Bug Report Instructions and post a recreation in JSBin/JSFiddle ? |
Just take the example code in the full-calendar-scheduler "simple" here: |
I've noted that it is happening on Chrome and Opera. I've also tested on Safari, Firefox and IE11 and it works pretty well. |
I think that it is getting scrambled here: https://github.com/fullcalendar/fullcalendar-scheduler/blob/7a5cc8d2335ad938b0329fe2cdccbd33c65e6fd7/src/common/ResourceDayTableMixin.coffee#L42 |
Implementing resourceOrder function seems to solve the problem: resourceOrder: function (a, b) {
return a.title < b.title ? -1 : a.title > b.title ? 1 : 0;
} |
@dizzleuk i've created this fiddle: http://jsbin.com/yedapokide/1/edit?js,output from what i can tell, in both Chrome and FF, without specifying the Adding a Knowing this information, @dizzleuk and @yokomizor , is there still a problem? |
It seems to occur only using agendaDay view. |
yes i was also using the day view. |
recreated, will fix. there is a workaround if you simply want to sort by title, just set |
Nice! Thank you. |
fixed in scheduler 1.2.0, released |
Is it possible this is still not working correctly? also adding resource order: |
The fix was that if no resourceOrder is specified, it should render the resources in the order they were specified. This seems to be correctly happening in your first demo |
Hi having around 15 resources trying to be rendered in the resource view for this example:
http://fullcalendar.io/js/fullcalendar-scheduler-1.1.0-beta2/demos/agenda-views.html
using code like this:
resources: [
{ id: 'a', title: 'Room A' },
{ id: 'b', title: 'Room B', eventColor: 'green' },
{ id: 'c', title: 'Room C', eventColor: 'orange' },
{ id: 'd', title: 'Room D', eventColor: 'red' },
{ id: 'e', title: 'Room E' },
{ id: 'f', title: 'Room F', eventColor: 'green' },
{ id: 'g', title: 'Room G', eventColor: 'orange' },
{ id: 'h', title: 'Room H', eventColor: 'red' },
{ id: 'i', title: 'Room I' },
{ id: 'j', title: 'Room J', eventColor: 'green' },
{ id: 'k', title: 'Room K', eventColor: 'orange' },
{ id: 'l', title: 'Room L', eventColor: 'red' },
{ id: 'm', title: 'Room M', eventColor: 'red' },
{ id: 'n', title: 'Room N', eventColor: 'red' },
{ id: 'o', title: 'Room O', eventColor: 'red' }
],
will cause the following errors:
the resource headings are no longer in order a->z
scroll bars should be appended to the bottom when lots of resources are rendered
Hopefully this helps you
Best Regards
The text was updated successfully, but these errors were encountered: