-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Travis to run automated tests #3218
Conversation
Changes: * Remove (done) from describe callback (invalid) * PhantomJS: 1.x -> 2.x * Bump other supporting dev dependencies * Add default "npm test" command, which points to headless tests
- 'stable' | ||
|
||
before_script: | ||
- bower install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will npm install
get run as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replied in the main PR, but for the sake of others reading here: yes. By default Travis uses npm install
and the test
command by default for node. Which is nice, because it has created a lot of consistency between hundreds (if not thousands) of OSS projects.
this is awesome! will be very valuable to the project, thanks. I'm having a tough time with Travis's UI figuring out where I can see what tests exactly failed. any pointers on how to get that insight? |
On Travis, I'm away from the computer otherwise id link you, but if you click around
|
Sample job link https://travis-ci.org/avindra/fullcalendar/jobs/137090725 In order to enable Travis, you'll have to log in via oauth, give Travis permissions and enable tracking per repo (i.e., fullcalendar/fullcalendar). The next commit and subsequent prs should trigger automatic builds 😀 |
awesome. this will be merged into master for the next release. i'll bug you and/or look at TravisCI docs if I have any more questions. thanks! |
Code complete and slated for v2.8.0 (wip docs). Will notify when released. Will deal with those failing tests soon. |
Thanks! Have you set up the travis integration yet? I don't see any builds at: |
i got it set up. it's really cool. i made a separate ticket to solve the failing tests: thanks |
This sets up the basic infrastructure for testing on Travis. Detected some issues with the
describe
callbacks when upgrading the deps, so I fixed those.Currently 3 tests are failing. As there is no publicly available test history, it's hard to tell if these are failing due to bumping
devDeps
, or if they were failing to begin with.Benefits:
First test run resut:
https://travis-ci.org/avindra/fullcalendar/builds/137090723