Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Travis to run automated tests #3218

Closed
wants to merge 1 commit into from
Closed

Use Travis to run automated tests #3218

wants to merge 1 commit into from

Conversation

avindra
Copy link
Contributor

@avindra avindra commented Jun 12, 2016

This sets up the basic infrastructure for testing on Travis. Detected some issues with the describe callbacks when upgrading the deps, so I fixed those.

Currently 3 tests are failing. As there is no publicly available test history, it's hard to tell if these are failing due to bumping devDeps, or if they were failing to begin with.

Benefits:

  • Test suite will run against PR's automatically, saving review time 🎊
  • Can program the test suite to automatically test against jQuery 2.x and 3.x in the future using environment variables

First test run resut:

https://travis-ci.org/avindra/fullcalendar/builds/137090723

Changes:
 * Remove (done) from describe callback (invalid)
 * PhantomJS: 1.x -> 2.x
 * Bump other supporting dev dependencies
 * Add default "npm test" command, which points to headless tests
- 'stable'

before_script:
- bower install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will npm install get run as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replied in the main PR, but for the sake of others reading here: yes. By default Travis uses npm install and the test command by default for node. Which is nice, because it has created a lot of consistency between hundreds (if not thousands) of OSS projects.

@arshaw
Copy link
Member

arshaw commented Jun 12, 2016

this is awesome! will be very valuable to the project, thanks.

I'm having a tough time with Travis's UI figuring out where I can see what tests exactly failed. any pointers on how to get that insight?

@avindra
Copy link
Contributor Author

avindra commented Jun 12, 2016

On Travis, npm install runs by default for node, and npm test is the
default test command.

I'm away from the computer otherwise id link you, but if you click around
there's a job details section where you can expand the log and see all the
output determine which tests are failing
On Sun, Jun 12, 2016 at 3:33 PM Adam Shaw notifications@github.com wrote:

this is awesome! will be very valuable to the project, thanks.

I'm having a tough time with Travis's UI figuring out where I can see what
tests exactly failed. any pointers on how to get that insight?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3218 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAHvgF94hKSzHyZ8zcQ83AhHMMCiSj0Hks5qLF8NgaJpZM4Iz18R
.

@avindra
Copy link
Contributor Author

avindra commented Jun 12, 2016

Sample job link https://travis-ci.org/avindra/fullcalendar/jobs/137090725

In order to enable Travis, you'll have to log in via oauth, give Travis permissions and enable tracking per repo (i.e., fullcalendar/fullcalendar). The next commit and subsequent prs should trigger automatic builds 😀

@arshaw
Copy link
Member

arshaw commented Jun 14, 2016

awesome. this will be merged into master for the next release. i'll bug you and/or look at TravisCI docs if I have any more questions. thanks!

@arshaw arshaw added this to the v2.8.0 milestone Jun 19, 2016
@arshaw
Copy link
Member

arshaw commented Jun 19, 2016

Code complete and slated for v2.8.0 (wip docs). Will notify when released.

Will deal with those failing tests soon.

@arshaw arshaw closed this Jun 19, 2016
@arshaw
Copy link
Member

arshaw commented Jun 20, 2016

Released in v2.8.0. thank you @avindra

@avindra avindra deleted the travis branch June 20, 2016 13:25
@avindra
Copy link
Contributor Author

avindra commented Jun 20, 2016

Thanks! Have you set up the travis integration yet? I don't see any builds at:

https://travis-ci.org/fullcalendar/fullcalendar/

@arshaw
Copy link
Member

arshaw commented Jun 22, 2016

i got it set up. it's really cool. i made a separate ticket to solve the failing tests:
#3236

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants