Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove manual & deferred initialization #37

Closed
3 tasks done
fulls1z3 opened this issue Apr 7, 2017 · 0 comments
Closed
3 tasks done

remove manual & deferred initialization #37

fulls1z3 opened this issue Apr 7, 2017 · 0 comments
Assignees
@fulls1z3
Labels
enhancement p2: required

Comments

@fulls1z3
Copy link
Owner

fulls1z3 commented Apr 7, 2017 •
edited

I'm submitting a ... (check one with "x")

[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[X] feature request

Current behavior
@nglibs/meta does not need anymore manual & deferred initialization as the meta tag generation is triggered by the MetaGuard.

Expected/desired behavior
The following steps will maintain the desired functionality:

  • Remove deferred initialization (no longer needed)
  • Remove manual initialization (no longer needed)
  • Remove documentation for deferred initialization (no longer needed)

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: 2.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

  • Node (for AoT issues): node --version =
@fulls1z3 fulls1z3 added this to the v0.2.0-rc.5 milestone Apr 7, 2017
@fulls1z3 fulls1z3 self-assigned this Apr 7, 2017
fulls1z3 pushed a commit that referenced this issue Apr 7, 2017
feat: remove manual & deferred initialization (#37)
a9257df
fulls1z3 pushed a commit that referenced this issue Apr 7, 2017
test: remove manual & deferred initialization (#37)
2271b6c
fulls1z3 pushed a commit that referenced this issue Apr 7, 2017
feat: remove manual & deferred initialization (#37)
c5479df
fulls1z3 pushed a commit that referenced this issue Apr 7, 2017
test: remove manual & deferred initialization (#37)
441c21b
@fulls1z3 fulls1z3 closed this as completed Apr 7, 2017
@fulls1z3 fulls1z3 modified the milestones: v0.2.0, v0.2.0-rc.5 Sep 3, 2017
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
feat(core): remove manual & deferred initialization (#37)
414c646
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
test(core): refactor unit tests
1279756 
test(core): set meta tags thru `MetaGuard` (#35)

test(core): remove manual & deferred initialization (#37)
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
feat(core): remove manual & deferred initialization (#37)
821144d
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
test(core): refactor unit tests
bb5b406 
test(core): set meta tags thru `MetaGuard` (#35)

test(core): remove manual & deferred initialization (#37)
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
feat(core): remove manual & deferred initialization (#37)
7473805
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
test(core): refactor unit tests
acf3ea2 
test(core): set meta tags thru `MetaGuard` (#35)

test(core): remove manual & deferred initialization (#37)
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
feat(core): remove manual & deferred initialization (#37)
d5fa3bc
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
test(core): refactor unit tests
b1a0dd3 
test(core): set meta tags thru `MetaGuard` (#35)

test(core): remove manual & deferred initialization (#37)
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
04ab8ae 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

build: update build config

build(npm): update deps

build(webpack): update config

refactor: update tsconfig

docs: update README
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
621e018 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* fix(core): updateLocales method does not clear `og:locale:alternate` tags (#33)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

build: update build config

build(npm): update deps

build(webpack): update config

refactor: update tsconfig

docs: update README
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
102feec 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* fix(core): updateLocales method does not clear `og:locale:alternate` tags (#33)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

* build: update build config

* build(npm): update deps

* build(webpack): update config

* refactor: update tsconfig

* docs: update README
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
f1bdf83 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

* build: update build config

* build(npm): update deps

* build(webpack): update config

* refactor: update tsconfig

* docs: update README
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
f8f6504 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* fix(core): updateLocales method does not clear `og:locale:alternate` tags (#33)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

* build: update build config

* build(npm): update deps

* build(webpack): update config

* refactor: update tsconfig

* docs: update README
fulls1z3 pushed a commit that referenced this issue Sep 4, 2017
chore(core): add new features
cc441b9 
* feat(core): prevent direct DOM manipulation (#31)

* test(core): add unit tests (#31)

* feat(core): remove `[].slice.call(elements)` (#34)

* feat(core): set meta tags thru `MetaGuard` (#35)

* test(core): add unit tests (#35)

* feat(core): remove manual & deferred initialization (#37)

* test(core): add unit tests (#37)

* fix(core): combine observables (#36)

* fix(core): support Promises at the `callback` function (#25)

* build: update build config

* build(npm): update deps

* build(webpack): update config

* refactor: update tsconfig

* docs: update README
@fulls1z3 fulls1z3 changed the title [enhancement] remove manual & deferred initialization remove manual & deferred initialization Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fulls1z3 fulls1z3

Labels
enhancement p2: required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fulls1z3