Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add network and json utils #13

Merged
merged 3 commits into from Mar 9, 2020
Merged

add network and json utils #13

merged 3 commits into from Mar 9, 2020

Conversation

@sabrina-li
Copy link
Contributor

sabrina-li commented Mar 6, 2020

adding two utils for making network calls.
network_security_config file is required for making API call for non-ssl connections. the config file itself is gitignored and the in manifest marked as dev only

<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/AppTheme" >
android:theme="@style/AppTheme"
android:networkSecurityConfig="@xml/network_security_config">

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Mar 7, 2020

Member

since network_security_config is .gitignored, will adding it to the manifest here cause breakage if it's not present in the project (e.g.: someone forgot to add it when they cloned the repo, and then tried to run the application)?

This comment has been minimized.

Copy link
@sabrina-li

sabrina-li Mar 9, 2020

Author Contributor

should we not ignore the file (expose the URL in this repo)?
Also applies to the hosts files that I had added to gitignore for links that I did not want to be exposed to github(but maybe we should actually expose them)?

This comment has been minimized.

Copy link
@patrick-fs

patrick-fs Mar 9, 2020

Member

I think you're ok. I see now that you've added the network_security_config and there's plenty of warnings about not opening network activity to non-SSL endpoints in your comments. Go ahead and make an issue on your repo to expose an SSL endpoint for the product catalog so you can remove this config in the future.

@sabrina-li sabrina-li force-pushed the sabrina/networkutils branch from 4bd4beb to 046f408 Mar 9, 2020
Copy link
Member

patrick-fs left a comment

@sabrina-li sabrina-li merged commit 8aa5216 into master Mar 9, 2020
@sabrina-li sabrina-li deleted the sabrina/networkutils branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.