Auto capture console logs #78
Conversation
|
Updated jest dev dependencies and snapshots to resolve npm errors. |
RyanCommits
force-pushed
the
ryanwang/capture-console-logs
branch
from
637de7a
to
f5707fe
Compare
|
After discussion - we discovered new requirements: https://docs.google.com/document/d/1QAGpjrC96ePbY_-SugOYK9zFSaqh1HnkXh6CP5MrRp8 |
There was a problem hiding this comment.
Overall seems fine. Added my nit feedback to a stacked pr: #83
Two open issues:
- do we need to expose the safeStringify or can we use an OSS solution? Longer term if we want to maintain this functinality it seems best to do as a separate lib.
- It's unclear why we default to enable and not let the FSTA settings determine the initial state.
| Assert = 5, // Clamps to Error on Android | ||
| } | ||
|
|
||
| const consoleLevelMap = { |
| expect(oldConsoleError).toEqual(console.error); | ||
| }); | ||
|
|
||
| it('disableConsole does not overwrite third party overwrites', () => { |
| // default ON | ||
| consoleWatcher.enable(); |
There was a problem hiding this comment.
This is confusing, web-capture doesn't default to ON. We default to disabled and only enable when there is a flags.ConsoleWatcher set to true on the PageResponse. The only exception is the FS.log API which adds logs.
src/logging/consoleCapture.ts
Outdated
| // @ts-expect-error | ||
| const isTurboModuleEnabled = global.__turboModuleProxy != null; |
There was a problem hiding this comment.
Seems like you need to define a module for the global scope instead of just ignoring the TS errors.
This should work.
declare global {
let __turboModuleProxy: boolean;
}
const isTurboModuleEnabled = __turboModuleProxy != null;There was a problem hiding this comment.
I've added this to my pr feedback branch.
src/logging/consoleCapture.ts
Outdated
| // A naive version of ConsoleWatcher on web. | ||
| // See https://github.com/cowpaths/mn/blob/865353f374b687e481d3b230e7eec8e1d7be2eb4/projects/fullstory/packages/recording/src/consolewatcher.ts |
There was a problem hiding this comment.
this is a public repo correct? doesn't seem that useful to ref our private repo
| @@ -0,0 +1,174 @@ | |||
| import { safeStringify } from '../logging/safeStringify'; | |||
There was a problem hiding this comment.
since this is a public repo seems like we could add a third-party dep for this instead of managing this directly.
Wiz Scan Summary
|
RyanCommits
force-pushed
the
ryanwang/capture-console-logs
branch
from
23dcb27
to
ac6011c
Compare
|
Closing this for now since we'll need to discuss console scrubbing on the native side |
Issue: https://fullstory.atlassian.net/browse/MOCA-8076
Add methods
enableConsoleanddisableConsoleto FullStory API that will extend React Native'sconsoleAPI. Messages will be passed toFS.log.Console capture defaults to enabled, and follows the FS default log level of
infoif the customer hasn't configured it already.Example session: https://app.staging.fullstory.com/ui/KWH/session/6727898337050624:5966357937455104/devtools/console
Added enable and disable API.
Added
safeStringifyfrom web side, minusDOMnode handling since that's not defined in RN.