clint - pr feedback for #78 #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurassix
changed the base branch from
master
to
ryanwang/capture-console-logs
jurassix
commented
Jan 17, 2024
Comment on lines
+60
to
+62
| if (!this._isActive) { | ||
| return | ||
| } |
There was a problem hiding this comment.
prefer to short circuit over indent
jurassix
commented
Jan 17, 2024
| this._shims[logLevel as ConsoleLevels] = undefined; | ||
| } | ||
| this._isActive = false; | ||
| let logLevel: ConsoleLevels; |
There was a problem hiding this comment.
we can drop all the casts by strongly typing the key.
jurassix
commented
Jan 17, 2024
| @@ -73,6 +72,7 @@ declare global { | |||
| fsTagName?: string; | |||
| } | |||
| } | |||
| let __turboModuleProxy: boolean; | |||
There was a problem hiding this comment.
define the variable on the global scope
jurassix
commented
Jan 17, 2024
src/logging/consoleCapture.ts
Outdated
| @@ -44,7 +43,6 @@ const logEvent = (level: LogLevel, args: ArrayLike<unknown>) => { | |||
| }; | |||
|
|
|||
| // A naive version of ConsoleWatcher on web. | |||
| // See https://github.com/cowpaths/mn/blob/865353f374b687e481d3b230e7eec8e1d7be2eb4/projects/fullstory/packages/recording/src/consolewatcher.ts | |||
There was a problem hiding this comment.
doesn't seem useful to ref an internal repo
jurassix
commented
Jan 17, 2024
src/logging/consoleCapture.ts
Outdated
| @@ -30,7 +29,7 @@ type ConsoleLevels = keyof typeof consoleLevelMap; | |||
| type MethodShim = Record<'native' | 'override', Function>; | |||
|
|
|||
| type ConsoleShims = { | |||
| [K in keyof typeof consoleLevelMap]?: MethodShim | null; | |||
There was a problem hiding this comment.
keyof typeof consoleLevelmap is already defined above as ConsoleLevels
RyanCommits
force-pushed
the
ryanwang/capture-console-logs
branch
from
23dcb27
to
ac6011c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.