Skip to content

Commit

Permalink
don't use TLS 1.3, which isn't quite right yet in Go tip (#66)
Browse files Browse the repository at this point in the history
  • Loading branch information
jhump committed Nov 16, 2018
1 parent 0dea37e commit d86529b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions grpcurl.go
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,9 @@ func ClientTransportCredentials(insecureSkipVerify bool, cacertFile, clientCertF
// client certs. The serverCertFile and serverKeyFile must both not be blank.
func ServerTransportCredentials(cacertFile, serverCertFile, serverKeyFile string, requireClientCerts bool) (credentials.TransportCredentials, error) {
var tlsConf tls.Config
// TODO(jh): Remove this line once https://github.com/golang/go/issues/28779 is fixed
// in Go tip. Until then, the recently merged TLS 1.3 support breaks the TLS tests.
tlsConf.MaxVersion = tls.VersionTLS12

// Load the server certificates from disk
certificate, err := tls.LoadX509KeyPair(serverCertFile, serverKeyFile)
Expand Down

0 comments on commit d86529b

Please sign in to comment.