Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/udpa dependency reference #197

Closed

Conversation

kai5263499
Copy link

Update the upda dependency reference to fix this error I was seeing when running the go get github.com/fullstorydev/grpcurl/... installation step

package github.com/fullstorydev/grpcurl/cmd/grpcurl
	imports github.com/cncf/udpa/go/udpa/core/v1: cannot find package "github.com/cncf/udpa/go/udpa/core/v1" in any of:
	/usr/local/go/src/github.com/cncf/udpa/go/udpa/core/v1 (from $GOROOT)
	/home/wes/go/src/github.com/cncf/udpa/go/udpa/core/v1 (from $GOPATH)

@jhump
Copy link
Contributor

jhump commented Nov 30, 2020

The only changes in here, other than changing a bunch of imports to your own fork (which I clearly will not be able to accept), seems to be the way you are trying to pin the dependency.

However, it should already be pinned, indirectly, by the grpc-go module.

I think the issue is more complicated and likely has to do with your current working directory when you run go get .... I think the Go tool can end up running in GOPATH mode, depending on whether or not you are in a workspace or not. And in GOPATH mode, it is not using the go.mod constraints.

An issue has already been filed with upstream as this is a breaking change they introduced a little over a week ago: cncf/udpa#42

@jhump jhump closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants