-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Could we have a v1? #42
Comments
Is there any update on this? |
+1 on this, also depending on the old path, can we get a tag so we can pin to the old version? |
@htuch - this is important for gRPC to be able to declare it has "stable" xDS support. We can't have our builds breaking because something here is moved or deleted. |
We should consider whether we can migrate these protos from cncf/udpa to cncf/xds before tagging a v1. |
Deleting the generated Go code from this repo would break "stable" releases of gRPC-Go. We really should have raised this as an urgent, blocking issue before our first release with xDS support, but nobody noticed it at the time. In fact, it was a cleanup CL that moved us from using our own generated |
Actually, it's even more important for us to have a stable release of https://github.com/envoyproxy/go-control-plane, since we use protos from there extensively, vs. only one from here (ORCA). |
Got it. @dfawley can you explain what the migration path we could do to |
We should be able to migrate Once this repo is no longer needed, we could do patch releases for the previous 3 minor releases of grpc-go to reference the latest |
SG, I'll do the migration in the next day or two. At the same time, we will do the |
@htuch are there any updates on this effort? |
@dfawley I've started the cncf/xds migration. I'll try get some progress happening by early next week to get us to the right point here. |
When cncf/xds#5 merges, cncf/xds will be live, we can then validate against Envoy repo and cut the release. |
@dfawley let's move discussion to cncf/xds#2. |
gRPC-Go has a dependency on the
pb.go
s published from here. #40 changed the path of thesepb.go
s. Currently gRPC-Go's depends on a specific commit.It would be bad for us to depend on a v0 for any non-experimental features that we support. Is there a plan to publish a v1 anytime soon?
Thank you.
The text was updated successfully, but these errors were encountered: