mva/fix oe #31
Merged
mva/fix oe #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(running npm install did the reformat)
jison relies on some npm packages that have capitals in their name, which besides being no longer allowed for new packages by the npmjs repository, also breaks building ggencoder as an OpenEmbedded package: opkg ipk files do not allow capitals in their name. jison and async are only required when using the encoder from the commandline. By making it a devDependency, jison will still be installed when running npm install. But no longer when having ggencoder as a dependency on another project. Test by comparing npm install vs npm install --production fulup-bzh#30
|
Merge done, thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.