feedback #1
Open
feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akio0911
commented
Nov 28, 2021
Comment on lines
-21
to
-23
| private let backGroundColors = [UIColor(red: 255/255, green: 209/255, blue: 208/255, alpha: 1), | ||
| UIColor(red: 222/255, green: 246/255, blue: 154/255, alpha: 1), | ||
| UIColor(red: 203/255, green: 216/255, blue: 255/255, alpha: 1)] |
There was a problem hiding this comment.
backGroundColors は TableViewCell に移動
akio0911
commented
Nov 28, 2021
Comment on lines
+18
to
+21
| func configure(name: String, index: Int) { | ||
| nameLabel.text = name | ||
| commentLabel.text = "\(index + 1)番目の都道府県です" | ||
| backgroundColor = backGroundColors[index % backGroundColors.count] |
akio0911
commented
Nov 28, 2021
Comment on lines
-14
to
-16
| func getNameLabel() -> UILabel { | ||
| return nameLabel | ||
| } |
There was a problem hiding this comment.
これだと「名前の表示に UILabel を1つ、コメントの表示に UILabel を1つ使っている」という知識を外部に露出させているので、カプセル化の観点からあまり好ましくはないと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.