Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Bost indicated after #224 was closed, cats does not compile when using jdk 10:
The issue is Clojurescript as of
1.9.946
uses a deprecated module,java.xml.bind.DataTypeConverter
, which it cannot find as it has been made non-default. The latest version of Clojurescript does not have this issue:Tests pass, as well, with the newest Clojurescript version:
$ lein test ... Ran 219 tests containing 374 assertions. 0 failures, 0 errors. $ node out/tests.js ... Ran 197 tests containing 340 assertions. 0 failures, 0 errors.
Also, jdk 11: