Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building on jdk 10/11 #226

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Allow building on jdk 10/11 #226

merged 1 commit into from
Dec 18, 2018

Conversation

Saityi
Copy link
Contributor

@Saityi Saityi commented Dec 17, 2018

As @Bost indicated after #224 was closed, cats does not compile when using jdk 10:

$ export JAVA_HOME=`/usr/libexec/java_home -v 10"
$ ./scripts/build
Exception in thread "main" java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter, compiling:(cljs/util.cljc:1:1)
...

The issue is Clojurescript as of 1.9.946 uses a deprecated module, java.xml.bind.DataTypeConverter, which it cannot find as it has been made non-default. The latest version of Clojurescript does not have this issue:

$ git diff
...
-                 [org.clojure/clojurescript "1.9.946" :scope "provided"]
+                 [org.clojure/clojurescript "1.10.439" :scope "provided"]
...
$ git clean -dxf
...
$ ./scripts/build
...
...
... done. Elapsed 15.111055842 seconds

Tests pass, as well, with the newest Clojurescript version:

$ lein test
...
Ran 219 tests containing 374 assertions.
0 failures, 0 errors.

$ node out/tests.js
...
Ran 197 tests containing 340 assertions.
0 failures, 0 errors.

Also, jdk 11:

$ export JAVA_HOME=`/usr/libexec/java_home -v 11`
$ ./scripts/build
... done. Elapsed 24.733712635 seconds

Current clojurescript version used in cats uses a module deprecated in java 10, but the latest Clojurescript version does not have this issue.
@Saityi Saityi changed the title Allow building on jdk 10 Allow building on jdk 10/11 Dec 17, 2018
@sovelten sovelten merged commit 38c1960 into funcool:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants