"Or very weak" filter koan is skipped

[sl4m]

Ironically enough, the koan below is skipped over because __ technically returns a keyword and is used as the filter which lets everything through. Not sure how to resolve this one, but bringing it to your attention.

in higher_order_functions.clj

  "Or very weak"
  (= '(:anything :goes :here) (filter (fn [x] __) '(:anything :goes :here)))

[trptcolin]

Good call. I need to revisit the already-passing side of the test suite and see why it's not catching things like this. It should be.

[calebphillips]

I was looking at this a couple of months back and if I read the code right, each meditation fails if any of the tests within it fail. So, ensure-failing-without-answers just tests that each koan has at least one failing test. I wanted to experiment with a testing macro that changed the meditations in some way (maybe negating each test result and updating the answer sheet to expect the negated meditations to pass) so that it could make sure every test failed, but I haven't made the time to play with it.

[trptcolin]

Skim - thanks again for the report.

Caleb - thanks for the macro-replacement idea. That's done now. I verified the new hotness catches this issue. It's a bit messy for now, but does the trick just fine.

[dsouth]

Again, this is still happening in the zip download. Perhaps I should just fork and have fun? :)

[trptcolin]

Thanks for the heads-up. I uploaded the latest code as a zip file: https://github.com/downloads/functional-koans/clojure-koans/clojure-koans-2011-09-22.zip. The previously latest version was from August 1 (before this fix).

I need to figure out a way to automate this - would love suggestions on how if you have any.

[dsouth]

As a lowly Java dev, the only automation I know for this is Ant. Would be happy to have a look into if you let me know the steps you require for creating and making the .zip available.

[trptcolin]

Yeah, by "automate" I mean have this jar built & uploaded when I commit to the github repo. After sleeping on it overnight, it seems easy enough to build the shell script I use for this into the repo itself. Thanks again for the report.

[dsouth]

My after sleeping on it is, "Shouldn't Lein be able to do that?" :)

[trptcolin]

Lein absolutely could do that. I'm thinking of a script/deploy_koans.sh that does:

git push origin master
zip # [bunch of options redacted]
echo "Hey Colin, don't be a dummy - upload the zipfile!"

...since github's uploader is based on flash and not so API-friendly. Kind of low-tech, but this'll fix the immediate issue. I'm sure something clever exists for this, will try to take a look this afternoon.

[dsouth]

A) I'm conscious of how off topic we are on this issue, but don't
think what we are discussing is worthy of its own issue?

B) I would almost never suggest this since the zip file is an artifact
of the repository, but maybe the simple answer is to version the zip
file, then it's a simple matter of pushing the changes???

[trptcolin]

Right, I'd rather not add the zip file (or even the jars in the lib directory) to the repo. I think adding a release process is the right move - that's the way most projects run, after all :)