Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce package dependencies #28

Open
hadjipantelis opened this issue Oct 12, 2018 · 4 comments
Open

Reduce package dependencies #28

hadjipantelis opened this issue Oct 12, 2018 · 4 comments
Assignees

Comments

@hadjipantelis
Copy link
Member

For example: Within fitted.FPCA, Hmisc::approxExtrap(...) can probably be dropped in favour of stats::spline( method = "natural", ... ). The performance deterioration will probably be minimal but we will be able to drop the depend to Hmisc which is a big dependency. Similarly dependencies on pracma and/or MASS probably could be trimmed too.

@CrossD
Copy link
Member

CrossD commented Oct 12, 2018

I agree with dropping redundant dependencies. We may port Hmisc::approxExtrap to fdapace instead of using spline smoothing for the sake of minimizing changes. pracma may also be dropped, but I think since everyone has MASS installed it should be less of concern.

@hadjipantelis
Copy link
Member Author

Agreed. I am planning to make the replacement, check if we get too many unit-tests complaining and then potentially re-write if needed.

@ChingChuan-Chen
Copy link

ChingChuan-Chen commented Sep 24, 2019

I was working on matlab function interp in R.
I can contribute that code which is written in RcppArmadillo and verified. I think that it’s what you need.

You can find interp.cpp in url.
The test file is in here.

@hadjipantelis
Copy link
Member Author

hadjipantelis commented Sep 24, 2019

Hello ChingChuan, thanks for being interested to contribute to fdapace. fdapace doesn't depend on RccArmadillo so there is a bit of an issue of introducing a new dependency and potentially not dropping a single one. You are welcome to fork out fdapace and integrate your code, we will be happy to review the relevant pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants