Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdb still locks #12

Closed
septag opened this issue Oct 16, 2018 · 2 comments
Closed

Pdb still locks #12

septag opened this issue Oct 16, 2018 · 2 comments

Comments

@septag
Copy link
Contributor

septag commented Oct 16, 2018

Hi,
I was testing out your library and noticed that on visual studio 2015 (update 3) it still locks the original pdb.
I have checked cr_pdb_replace function to see if the pdb name is replaced and it does, but after cr_so_load, the original pdb is locked instead of versioned one.
does visual studio gets it's pdb path from somewhere else instead of binary ?
@septag
Copy link
Contributor Author

septag commented Oct 16, 2018

I have found the problem. before cr_plugin_load, I had to load and unload the dll to execute a function. but visual studio didn't seem to unlock the pdb.
The lock was gone with the solution mentioned here

sorry to bother you and thanks for the great lib

@septag septag closed this as completed Oct 16, 2018
@fungos
Copy link
Owner

fungos commented Oct 17, 2018

Thanks for the link, that is interesting and remembers me that I have some more things to write in the troubleshooting section, I'll take the time and add this info there too.

datgame added a commit to datgame/cr that referenced this issue Mar 9, 2019
@datgame
fix initial dll lock in visual studio 2017
348eb77 
same problem as fungos#12
the original pdb is locked for some reason if the pdb-string is garbled, as it was without a terminating zero.
original path:
"d:\\dev\\netphys\\_build_win_d\\game\\game.pdb"
patched:
"gam0.pdbetphys\\_build_win_d\\game\\game.pdb"
after bugfix:
"gam0.pdb\0etphys\\_build_win_d\\game\\game.pdb"
@datgame datgame mentioned this issue Mar 9, 2019
Merged
fungos pushed a commit that referenced this issue Mar 28, 2019
@datgame @fungos
Fix instance of pdb lock cause by garbage in the pdb filename
04a94a3 

Add option to not check for library changes.

* tidy up + fix variable shadow warning

Fix the documentation
Add braces to the condition
Rename check to reloadCheck
update README.md
fix variable shadow warning, -we4456  declaration of 'x' hides previous local declaration. on msvc

* fix outdated docs

i dont understand git :-)

* fix initial dll lock in visual studio 2017

same problem as #12
the original pdb is locked for some reason if the pdb-string is garbled, as it was without a terminating zero.
original path:
"d:\\dev\\netphys\\_build_win_d\\game\\game.pdb"
patched:
"gam0.pdbetphys\\_build_win_d\\game\\game.pdb"
after bugfix:
"gam0.pdb\0etphys\\_build_win_d\\game\\game.pdb"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fungos @septag