1. Strings #8

[RobertMili]

1. Change the name of class and test class
2. More test were written
3. This was made with a verified account

[safstromo]

You need to rename your classes, they cant be named "Redis".

I think the best solution would be to:
Merge your code with Origin main you can put your code in the HazeDatabase class methods instead.
Put your code inside the locks so that only one client can write to the database at time.

[BobHogvall]

Great work Robert! Just a small note:

Perhaps not the most important but if we want to follow the standard for test writing we should remove "public" from the tests: "JUnit5 test classes and methods should have default package visibility"

example:
@test
void testSetWithValidKeyValuePair() {}

We should be able to see this in sonarCloud as well! If you have sonarLint on your local computer it should be visible there as well.

Regards!

[RobertMili]

Great work Robert! Just a small note:

Perhaps not the most important but if we want to follow the standard for test writing we should remove "public" from the tests: "JUnit5 test classes and methods should have default package visibility"

example: @test void testSetWithValidKeyValuePair() {}

We should be able to see this in sonarCloud as well! If you have sonarLint on your local computer it should be visible there as well.

Regards!

Thank you for reviewing my code

[BobHogvall]

Maybe there was a misunderstanding, my bad, but I meant the tests in the test classes. All of them could be written with the default package visibility, which means you remove "public" from all the tests in the test class. This should also make sonarCloud happy and hopefully remove the red cross.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[BobHogvall]

Perfect!