-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1. Strings #8 #104
1. Strings #8 #104
Conversation
RobertMili
commented
Feb 14, 2023
- Change the name of class and test class
- More test were written
- This was made with a verified account
2. More test were written
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rename your classes, they cant be named "Redis".
I think the best solution would be to:
Merge your code with Origin main you can put your code in the HazeDatabase class methods instead.
Put your code inside the locks so that only one client can write to the database at time.
2. More test were written 3. Merge Redis Server to class HazeDatabase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Robert! Just a small note:
Perhaps not the most important but if we want to follow the standard for test writing we should remove "public" from the tests: "JUnit5 test classes and methods should have default package visibility"
example:
@test
void testSetWithValidKeyValuePair() {}
We should be able to see this in sonarCloud as well! If you have sonarLint on your local computer it should be visible there as well.
Regards!
Thank you for reviewing my code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there was a misunderstanding, my bad, but I meant the tests in the test classes. All of them could be written with the default package visibility, which means you remove "public" from all the tests in the test class. This should also make sonarCloud happy and hopefully remove the red cross.
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!