Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76 lindex to lists #184

Merged
merged 31 commits into from
Feb 9, 2024
Merged

76 lindex to lists #184

merged 31 commits into from
Feb 9, 2024

Conversation

robinalfengard
Copy link
Contributor

Added method for Lindex + tests

jLereback and others added 23 commits February 20, 2023 16:12
@jLereback
Refactor Main.java
cda2f75
@cmatlak
Updated getInitializeMetod and moved it to Initialize class
26ac191
@cmatlak
Updated getInitializeMetod and moved it to Initialize class (#179)
3e153e0 
fshould fix the old pull request denial on refactor main
@cmatlak
Updated getInitializeMetod and moved it to Initialize class + version…
aab9ed7 
… updates
@cmatlak
Merge branch '115-refactor-main-OldPullRequst-Fix' of https://github.…
f755f10 
…com/fungover/haze into 115-refactor-main-OldPullRequst-Fix
@cmatlak
115 refactor main old pull requst fix (#180)
beb05ef 
fix versions from old pull request
@cmatlak
Merge branch 'main' into 115-refactor-main
b5feeb8
@cmatlak
docker update
3107794
@cmatlak
Merge remote-tracking branch 'origin/main' into 115-refactor-main-Old…
d54c9ae 
…PullRequst-Fix

# Conflicts:
#	src/main/java/org/fungover/haze/Main.java
@cmatlak
version changes
019527b
@cmatlak
removed outdated preview code
fff28c9
@cmatlak
fix return type in executeCommand method
ccb2f58
@cmatlak
getInitialize method in Initialize class
469b517
@cmatlak
Merge branch '115-refactor-main' into 115-refactor-main-OldPullRequst…
99c12e8 
…-Fix
@cmatlak
fixed errors after update
b2cf5cf 
Co-authored-by:  robinalfengard<robin.alfengard@hotmail.com>
@cmatlak
Add test methods on Main.test
878d88a 
Co-authored-by:  robinalfengard<robin.alfengard@hotmail.com>
@cmatlak
update pom.xml, removing redundant methods in test
18534d3
@cmatlak @robinalfengard
merge branch to latest config
e3b130d
@robinalfengard
Add test for initializeServer method in main
b2a7f62
@robinalfengard
Add test for shutDownClientIfNotAuthenticated in main class
ba80c92
@robinalfengard
Add test for initSocket method in main
00dd4b8
@robinalfengard
Adjustment for test for initSocket method in main
f254836
@robinalfengard
Add code + tests for Lindex method
eed3f83
@robinalfengard robinalfengard linked an issue Feb 6, 2024 that may be closed by this pull request
LINDEX to lists #76
Closed
kappsegla
kappsegla requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mayor changes needed since LINDEX command is a command that works on list keys.

src/main/java/org/fungover/haze/Command.java Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/Main.java Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/Main.java Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/HazeDatabase.java Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/HazeDatabase.java Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/Main.java Show resolved Hide resolved
src/test/java/org/fungover/haze/HazeDatabaseTest.java Outdated Show resolved Hide resolved
src/test/java/org/fungover/haze/MainTest.java Outdated Show resolved Hide resolved
kappsegla
kappsegla previously approved these changes Feb 7, 2024
View reviewed changes
src/main/java/org/fungover/haze/HazeDatabase.java Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/Initialize.java Outdated Show resolved Hide resolved
kappsegla
kappsegla previously approved these changes Feb 7, 2024
View reviewed changes
cmatlak
cmatlak previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@cmatlak cmatlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good testing methods

@robinalfengard robinalfengard dismissed stale reviews from cmatlak and kappsegla via 08cc00e February 9, 2024 11:21
@cmatlak
Copy link
Contributor

cmatlak commented Feb 9, 2024 •
edited
Loading

Could the issue with compiling be the same a Martin saw today? with the multiple files in pom?
never mind i saw your comment with the comma

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cmatlak
cmatlak approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@cmatlak cmatlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Lucia560
Lucia560 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@Lucia560 Lucia560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@robinalfengard robinalfengard added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 8a8f3eb Feb 9, 2024
3 checks passed
@robinalfengard robinalfengard deleted the 76-lindex-to-lists branch February 9, 2024 12:16
@robinalfengard robinalfengard self-assigned this Feb 9, 2024
@kappsegla kappsegla added enhancement New feature or request minor labels Feb 9, 2024
@altmannk altmannk mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmatlak cmatlak cmatlak approved these changes

@Lucia560 Lucia560 Lucia560 approved these changes

@kappsegla kappsegla kappsegla left review comments

Assignees

@robinalfengard robinalfengard

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LINDEX to lists
5 participants
@robinalfengard @cmatlak @kappsegla @Lucia560 @jLereback