Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LSET method,update switch and enum class #188

Merged
merged 36 commits into from
Feb 13, 2024
Merged

Added LSET method,update switch and enum class #188

merged 36 commits into from
Feb 13, 2024

Conversation

cmatlak
Copy link
Contributor

@cmatlak cmatlak commented Feb 7, 2024

LSET method added to list

@cmatlak cmatlak linked an issue Feb 7, 2024 that may be closed by this pull request
LSET to list #78
Closed
cmatlak and others added 2 commits February 7, 2024 14:02
@cmatlak @robinalfengard
Add test methods for LSET method
1843393 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add another test method on LSET
4a4470a 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
TrungMa1
TrungMa1 requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@TrungMa1 TrungMa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply some unit test to achieve more code coverage. Otherwise this looks good to me!

@cmatlak
Copy link
Contributor Author

cmatlak commented Feb 7, 2024

yes thank you for input, test are in the making

cmatlak and others added 4 commits February 7, 2024 20:18
@cmatlak @robinalfengard
Add test methods for LSET method
0a0175a 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add test methods for LSET method
23fd533 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak
changed stream.collect to stream.tolist
4a38ccf
@cmatlak
Add more unit test on hazelist
560e172
altmannk
altmannk reviewed Feb 7, 2024
View reviewed changes
Copy link

@altmannk altmannk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you are adding more tests now. Looking good! Just a reminder to cover these as well. 😊 Happy coding!

src/main/java/org/fungover/haze/HazeList.java Show resolved Hide resolved
@kappsegla kappsegla added feature Marks a pull request as a new feature minor labels Feb 9, 2024
altmannk
altmannk reviewed Feb 9, 2024
View reviewed changes
Copy link

@altmannk altmannk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong. It looks like there was a merge into main (#184) before you merged main into your branch. Maybe you missed to update main locally before merging and thats the reason why your build tests are failing?

Screenshot 2024-02-09 at 16 40 17

src/main/java/org/fungover/haze/Command.java Outdated Show resolved Hide resolved
cmatlak and others added 8 commits February 11, 2024 13:15
@cmatlak
Added LSET method,update switch and enum class
3ca1056
@cmatlak @robinalfengard
Add test methods for LSET method
80f1adb 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add another test method on LSET
5b24cca 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add test methods for LSET method
30adba9 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add test methods for LSET method
b7e7dfa 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak
changed stream.collect to stream.tolist
1ffb863
@cmatlak
Add more unit test on hazelist
47d42fb
@cmatlak
Add more unit test on hazelist for wrong number of arguments
fb0f187
cmatlak and others added 15 commits February 11, 2024 13:23
@cmatlak
Add more unit test on hazelist for non existing key
2d1cd9b
@cmatlak
Add more unit test on hazelist for lSetwithWrongIndex
cc09a9c
@cmatlak
fixed an error
08cdf2d
@cmatlak
Added LSET method,update switch and enum class
c831d3e
@cmatlak @robinalfengard
Add test methods for LSET method
69a0a19 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add another test method on LSET
bd8c2ab 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add test methods for LSET method
7bf6000 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak @robinalfengard
Add test methods for LSET method
02eedd0 
Co-authored-by: robinalfengard <robin.alfengard@hotmail.com>
@cmatlak
Add more unit test on hazelist
86fe468
@cmatlak
Add more unit test on hazelist for wrong number of arguments
b88f314
@cmatlak
Add more unit test on hazelist for non existing key
121a745
@cmatlak
Add more unit test on hazelist for lSetwithWrongIndex
d417e7b
@cmatlak
fixed an error
911e16e
@cmatlak
fixed errors
ea51a23
@cmatlak
Merge remote-tracking branch 'origin/78-lset-to-list' into 78-lset-to…
b49c0e4 
…-list

# Conflicts:
#	src/main/java/org/fungover/haze/Command.java
#	src/main/java/org/fungover/haze/Main.java
#	src/test/java/org/fungover/haze/HazeListTest.java
#	src/test/java/org/fungover/haze/integration/HazeIT.java
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
94.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TrungMa1
TrungMa1 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@TrungMa1 TrungMa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Well done!

robinalfengard
robinalfengard approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@robinalfengard robinalfengard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@robinalfengard robinalfengard added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit a831aa4 Feb 13, 2024
3 checks passed
@robinalfengard robinalfengard deleted the 78-lset-to-list branch February 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altmannk altmannk altmannk left review comments

@robinalfengard robinalfengard robinalfengard approved these changes

@TrungMa1 TrungMa1 TrungMa1 approved these changes

Assignees
No one assigned
Labels
feature Marks a pull request as a new feature minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSET to list
5 participants
@cmatlak @robinalfengard @TrungMa1 @altmannk @kappsegla