Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some more Argumentexceptions to handle wrong inputs #135 #187

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Added some more Argumentexceptions to handle wrong inputs #135 #187

merged 2 commits into from
Feb 7, 2024

Conversation

TrungMa1
Copy link
Contributor

@TrungMa1 TrungMa1 commented Feb 7, 2024 •
edited

Added exceptions to handle wrong inputs #135

@TrungMa1 TrungMa1 self-assigned this Feb 7, 2024
robinalfengard
robinalfengard requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@robinalfengard robinalfengard left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed. Looks like HazeDatabaseTest.testSendingInNoParametersToExistsMethodReturnsZero is causing some problems. It expects ":0\r\n", since the method exists previously returned 0 if no key where found.

@TrungMa1 TrungMa1 assigned TrungMa1 and unassigned TrungMa1 Feb 7, 2024
@TrungMa1 TrungMa1 closed this Feb 7, 2024
@TrungMa1 TrungMa1 reopened this Feb 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
61.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TrungMa1
Copy link
Contributor Author

TrungMa1 commented Feb 7, 2024

Build failed. Looks like HazeDatabaseTest.testSendingInNoParametersToExistsMethodReturnsZero is causing some problems. It expects ":0\r\n", since the method exists previously returned 0 if no key where found.

Thank you Robin!

robinalfengard
robinalfengard approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@robinalfengard robinalfengard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good follow up, looks good!

@TrungMa1 TrungMa1 changed the title Added some more Argumentexceptions to handle wrong inputs Added some more Argumentexceptions to handle wrong inputs #135 Feb 7, 2024
cmatlak
cmatlak approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@cmatlak cmatlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid

@kappsegla kappsegla added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit cecbf44 Feb 7, 2024
5 checks passed
@kappsegla kappsegla deleted the feature1 branch February 7, 2024 16:09
@robinalfengard robinalfengard mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinalfengard robinalfengard robinalfengard approved these changes

@cmatlak cmatlak cmatlak approved these changes

Assignees

@TrungMa1 TrungMa1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TrungMa1 @robinalfengard @cmatlak @kappsegla