Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 refactor main #206

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

115 refactor main #206

wants to merge 45 commits into from

Conversation

cmatlak
Copy link
Contributor

@cmatlak cmatlak commented Feb 9, 2024

No description provided.

@robinalfengard
Copy link
Contributor

robinalfengard commented Feb 9, 2024

Build failed. According to report: "/home/runner/work/haze/haze/src/main/java/org/fungover/haze/Main.java:[133,20] the switch expression does not cover all possible input values"
Maybe compare commands from Command class with cases in the switch?

@Lucia560
Copy link
Contributor

Lucia560 commented Feb 9, 2024

Is the switch missing the default case ? Also , in the workflow should the lines 30-39 be kept? maven compile and maven test .

@ValentinaSukonina
Copy link
Contributor

ValentinaSukonina commented Feb 11, 2024

There is a compilation problem due to the missing parts in the MainTest:

line 118-128
@test
@DisplayName("getInputList Should Return List With Correct Data Based On Index")
This test is missing closing bracket "}".

line 130
This test is missing the starting line (@test)
(void callExecuteCommandWithIncrShouldIncreaseTheValueOfTheKeyBy1())

Copy link
Contributor

@ValentinaSukonina ValentinaSukonina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required in maven.yml, MainTest - code is not compiling

src/test/java/org/fungover/haze/MainTest.java Show resolved Hide resolved
src/main/java/org/fungover/haze/Main.java Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
src/main/java/org/fungover/haze/Main.java Outdated Show resolved Hide resolved
Copy link

@BarbieQkiller BarbieQkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, splitting the main method makes the code a lot more readable :)

Copy link
Contributor

@ValentinaSukonina ValentinaSukonina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve conflicts with origin/main

maxerkmar
maxerkmar previously approved these changes May 27, 2024
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants