-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
115 refactor main #206
base: main
Are you sure you want to change the base?
115 refactor main #206
Conversation
# Conflicts: # pom.xml # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
…ests, need to be replaced
…Fix' into 115-refactor-main-OldPullRequst-Fix # Conflicts: # pom.xml # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
Build failed. According to report: "/home/runner/work/haze/haze/src/main/java/org/fungover/haze/Main.java:[133,20] the switch expression does not cover all possible input values" |
Is the switch missing the default case ? Also , in the workflow should the lines 30-39 be kept? maven compile and maven test . |
There is a compilation problem due to the missing parts in the MainTest: line 118-128 line 130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required in maven.yml, MainTest - code is not compiling
…ctor-main # Conflicts: # src/main/java/org/fungover/haze/Main.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, splitting the main method makes the code a lot more readable :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, resolve conflicts with origin/main
|
No description provided.