115 refactor main old pull requst fix #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Adding test for that class
2. Adding test for that class 3. Adding more test on MainTest.java
…o-respinputparserjava
Squash comments
Integration tests that starts the server on a random free port. Tests for the following commands: PING - PONG SETNX SET - GET DELETE EXISTS Error for not implemented command
Change initialization of ServerSocket setReuseAddress true to happen before binding. Otherwise, the reuse address option doesn't work.
…-lists' into 50-integration-tests # Conflicts: # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
When running tests testcontainers uses slf4j to do logging. Without an implementation an error message will be printed.
…commands-dont-work-with-lists' into 50-integration-tests # Conflicts: # src/test/java/org/fungover/haze/MainTest.java
Before building new docker images during release integration tests will be run. The command is now mvn -B verify.
Bumps [mockito-core](https://github.com/mockito/mockito) from 5.1.1 to 5.3.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.1.1...v5.3.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Integration tests that starts the server on a random free port. Tests for the following commands: PING - PONG SETNX SET - GET DELETE EXISTS Error for not implemented command
Change initialization of ServerSocket setReuseAddress true to happen before binding. Otherwise, the reuse address option doesn't work.
When running tests testcontainers uses slf4j to do logging. Without an implementation an error message will be printed.
|
Yes some kind of error are there, Will look in to it. Yes we can close the old one, don't know why i didnt update |
|
Replaces #161 |
Closed
Co-authored-by: robinalfengard<robin.alfengard@hotmail.com>
Co-authored-by: robinalfengard<robin.alfengard@hotmail.com>
# Conflicts: # Dockerfile # src/main/java/org/fungover/haze/Main.java
Merged
kappsegla
reviewed
Feb 6, 2024
# Conflicts: # pom.xml # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
…ests, need to be replaced
Mattan41
approved these changes
Feb 8, 2024
…Fix' into 115-refactor-main-OldPullRequst-Fix # Conflicts: # pom.xml # src/main/java/org/fungover/haze/Main.java # src/test/java/org/fungover/haze/MainTest.java
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed versions, updated with getInitialized method in right class, updated return type in getcommand method