-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
27 concurrent connections v2 #44
Conversation
Code looks good, what do you think of moving the connection functionality to another class for more OOP and readability? |
Cleanup
I think its a good idea, we could wait for merging day and create a separate issue for that? |
Smart! I agree, there's probably going to be an influx of java code soon, let's get that to work first and refactor after |
Add end line Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I'll request a change on some formatting and a refactored method 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot cleaner and better now. Great work!
Java code looks good but when looking at the pom.xml file it looks like every line almost has been replaced. Must be indentation that has changed from space to tab or something like that so git diff marks every line as replaced? |
0cd205b
to
9ea5875
Compare
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the pom.xml has the correct format 👍
Code for starting a new virtual thread for each connection
resolve #27