Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27 concurrent connections v2 #44

Merged
merged 17 commits into from
Feb 10, 2023
Merged

27 concurrent connections v2 #44

merged 17 commits into from
Feb 10, 2023

Conversation

safstromo
Copy link
Contributor

@safstromo safstromo commented Feb 7, 2023

Code for starting a new virtual thread for each connection
resolve #27

@MikaelEdwartz
Copy link
Contributor

Code looks good, what do you think of moving the connection functionality to another class for more OOP and readability?

@safstromo
Copy link
Contributor Author

safstromo commented Feb 7, 2023

Code looks good, what do you think of moving the connection functionality to another class for more OOP and readability?

I think its a good idea, we could wait for merging day and create a separate issue for that?
i think most of the clutter will disapear when the commands are sorted and the printlines are removed

@MikaelEdwartz
Copy link
Contributor

Code looks good, what do you think of moving the connection functionality to another class for more OOP and readability?

I think its a good idea, we could wait for merging day and create a separate issue for that? i think most of the clutter will disapear when the commands are sorted and the printlines are removed

Smart! I agree, there's probably going to be an influx of java code soon, let's get that to work first and refactor after

pom.xml Outdated Show resolved Hide resolved
Add end line

Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
MikaelEdwartz
MikaelEdwartz previously approved these changes Feb 8, 2023
jLereback

This comment was marked as outdated.

Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'll request a change on some formatting and a refactored method 🤗

src/main/java/org/fungover/haze/Main.java Show resolved Hide resolved
kappsegla
kappsegla previously approved these changes Feb 8, 2023
@kappsegla kappsegla added the feature Marks a pull request as a new feature label Feb 8, 2023
jLereback
jLereback previously approved these changes Feb 8, 2023
Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄

cchriss123
cchriss123 previously approved these changes Feb 8, 2023
Copy link
Contributor

@cchriss123 cchriss123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot cleaner and better now. Great work!

@kappsegla
Copy link
Contributor

kappsegla commented Feb 8, 2023

Java code looks good but when looking at the pom.xml file it looks like every line almost has been replaced. Must be indentation that has changed from space to tab or something like that so git diff marks every line as replaced?
I think it might be editorconfig that has a problem and specifies tabs instead of spaces. Made an issue #62 about the problem.

@safstromo safstromo dismissed stale reviews from cchriss123 and jLereback via 0cd205b February 10, 2023 08:32
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@jLereback jLereback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the pom.xml has the correct format 👍

@kappsegla kappsegla merged commit d8a3e06 into main Feb 10, 2023
@kappsegla kappsegla deleted the 27-concurrent-connections-v2 branch February 10, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Marks a pull request as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent Connections
5 participants