19 auth #57
Merged
19 auth #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Maybe you can find some tips here how to use env in your code and being able to test the behavior based on env values? A design using dependency injection might make the code more testable. |
Is the Security hotspot a problem since Surefire plugin is only used for tests? |
safstromo
requested review from
jLereback,
figgge,
kappsegla and
MikaelEdwartz
|
Ive added cli options to set password. run with "-pw 123" to set password 123 |
RobertMili
previously approved these changes
Feb 16, 2023
jLereback
suggested changes
Feb 16, 2023
There was a problem hiding this comment.
We have looked at your code and have a few questions that would be appreciated if you could answer. We also have a few suggestions that you could consider 🤗
Co-authored-by: Ahlberg-iths 113943951+ahlberg-iths@users.noreply.github.com
Fix test Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
cleanup parentheses Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
Fix boolean Co-authored-by: Julia Lerebäck Corell <112405931+jLereback@users.noreply.github.com>
|
SonarCloud Quality Gate failed. |
kappsegla
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class for authentication.
Anyone got ideas how to test environment variables?
Please add to test or create a separate issue :)