-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 setnx #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
the only change id like to see is the server responses (:0\r\n) etc. Make them a constant with a name for easier reading 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
94de81c
574da4a
to
94de81c
Compare
SonarCloud Quality Gate failed. |
For test from client I have used Jedis from https://github.com/kappsegla/Build23/tree/redis |
Would it be possible to add some functionality to retain more than one value? In issue #14 we need to add delete functionality, which can have n parameters. Or maybe add an extra if statement saying something in the lines of if(DEL) then save all the keys to a string which we then can split into each single keys for the HazeDatabase.del method? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks god. A bit more easy to read after last commit.
Code looks fine to me.
Add SETNX method in HazeDatabase and execute command in main.