Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to new classpath #31

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

vonfredd
Copy link
Contributor

@vonfredd vonfredd commented Feb 6, 2024

Related Issue

Closes #30

Proposed Changes

Update Dockerfile to new classpath

  • Change:
    ENTRYPOINT ["java", "-cp", "/thunder.jar", "org.fungover.Main"]
    updated to
    ENTRYPOINT ["java", "-cp", "/thunder.jar", "org.fungover.thunder.Main"]

@vonfredd vonfredd linked an issue Feb 6, 2024 that may be closed by this pull request
@vonfredd vonfredd self-assigned this Feb 6, 2024
@kappsegla kappsegla added this pull request to the merge queue Feb 6, 2024
Copy link
Contributor

@hannastigland hannastigland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changes, and the updated classpath seems correct.

Merged via the queue into main with commit ad71abd Feb 6, 2024
1 check passed
@kappsegla kappsegla deleted the 30-bug-wrong-entrypoint-in-dockerfile branch February 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Wrong Entrypoint in Dockerfile
3 participants