Sonarcloud ci #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kappsegla
force-pushed
the
sonarcloud-ci-based
branch
8 times, most recently
from
71a3e0d
to
1493894
Compare
kappsegla
force-pushed
the
sonarcloud-ci-based
branch
4 times, most recently
from
e7762a4
to
a585888
Compare
kappsegla
force-pushed
the
sonarcloud-ci-based
branch
6 times, most recently
from
7c8c7e1
to
79c6f54
Compare
PRs will be analyzed using SonarCloud with a CI based approach. Adds code coverage reporting using maven jacoco plugin. Updates maven.yaml to use java version based on pom.xml config.
kappsegla
force-pushed
the
sonarcloud-ci-based
branch
from
79c6f54
to
a1626d4
Compare
|
Emmelie83
approved these changes
Feb 6, 2024
I also tried to specify what changes and why in the first comment of the pullrequest. |
Yes, I know. :-) But I needed ChatGPT to understand lines like this: Java_Version=$(mvn help:evaluate "-Dexpression=maven.compiler.release" -q -DforceStdout | sed -e 's/^1./1.0./') :-) |
cmatlak
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Add more automatic checking of PR. The following changes are made:
maven.yml
Update maven.yml to detect java version from pom.xml setting maven.compiler.release instead of hard coding.
Check out more than top commit for better code analyzing. (fetch-depth: 0)
Add caching of downloaded sonar artifacts for faster runs in the future.
Add SonarCloud scanning of the code by adding sonar plugin to mvn and reports will be available in PR.
pom.xml
Add properties with settings for sonar.
Add code coverage report with jacoco plugin to pom.xml.