-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implementation of a way to disable the SPECIAL rules #20
Comments
Closing for now 😹 |
Let's reopen this then 👍 |
We'll need some exception rule for this one as well. |
By default, we test for public accessible domains @dnmTX. Those domains can be tested as After reading https://pi-hole.net/2018/09/10/mitigate-a-new-cert-vulnerability-598349-with-an-entry-in-etc-hosts/ I find it hard to exclude it for any test as every network may have its own local domain. Between I already handle part of the problem as all domain which ends or is exactly in one of the following are ignored when testing a file:
I'll not handle it @dnmTX. I prefer to handle a list of common local domains which can be found on the wild instead of setting a permissive rule which may exclude everything which starts with |
@funilrys about the P.S. Just as a example you look at the INACTIVE folder in @lightswitch05's lists and you can see how many are there and they are all very much ACTIVE/LIVE 😞 |
@dnmTX This tool was and is developed independently. @Ultimate-Hosts-Blacklist use PyFunceble which his own configuration and @dead-hosts use PyFunceble which its default configuration + what is needed to run under Travis CI. The SPECIAL rules are there and will stay there. Also, the SPECIAL rules are not only about taking down domains. For example, if I disable that all IP ranges will be set as inactive which is not great for the DNS server or user which take the IP range and converts them into a list of IP. The SPECIAL rules where developed because we did a constatation and we tested our constatation. Also, we were and are pretty sure that if the status code changes PyFunceble will put them into the We had over 70+ domains which could be into that SPECIAL rules for If you want a list with PyFunceble and only I will update the graphs in the coming versions (added to my backlog) in order to be and stay more transparent even if it was already well documented. Thanks for the critic but on this, the option is available now on the dev version. The SPECIAL rules will stay for now. I may disable it into @Ultimate-Hosts-Blacklist after consulting @mitchellkrogza but just not in the coming hours. I respect your opinion but sometime I can't follow every opinion. Cheers, |
Well...let me know what you guys came up with,especially about the |
Indeed, this patch introduce a way to quickly retest every special elements of PyFunceble in order to reintroduce domains which fill into Ultimate-Hosts-Blacklist/dev-center#16. Note: * This fix the issue partially because the `no_special` configuration index of PyFunceble (cf: funilrys/PyFunceble#20) will only be available for us (Ultimate-Hosts-Blacklist) from the next stable release. * Indeed we (Ultimate-Hosts-Blacklist) only use the stable version of PyFunceble. * Code does not need to be updated on next stable release of PyFunceble because the `no_special` index is beforehand implemented. * Normally the current code should be suffisant but keep in mind that this is just experimental until the next release of PyFunceble (keep yourself updated). * The new file will be called `volatile.list` Thanks to @dmtx for the effort. 😉
Describe the bug
Ultimate-Hosts-Blacklist/dev-center#16
The text was updated successfully, but these errors were encountered: