Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constant to edge distance implementation #96

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

cmalinmayor
Copy link
Contributor

@funkey Our tests were not thorough enough 🤦 We didn't actually add the constant cost!

@cmalinmayor cmalinmayor requested a review from funkey April 29, 2024 18:34
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (1400514) to head (5fdc024).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          33       33           
  Lines         816      817    +1     
=======================================
+ Hits          765      766    +1     
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor cmalinmayor merged commit 09f5c33 into main Apr 30, 2024
13 checks passed
@cmalinmayor cmalinmayor deleted the fix_edge_dist_cost branch April 30, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant