Enable strictNullChecks #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 96.22% 96.24% +0.02%
==========================================
Files 13 13
Lines 1508 1517 +9
Branches 136 146 +10
==========================================
+ Hits 1451 1460 +9
Misses 57 57
Continue to review full report at Codecov.
|
| [Symbol.iterator]: generator | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Instead of this change, what about implementing the linked list as an abstract class called List which Cons and Nil extends? Then the iterator and the isNil property could sit on the abstract class. I also think that would fit better with the rest of the code where we use abstract classes and classes that extend them to represent something like algebraic data types/sum types.
There was a problem hiding this comment.
Thanks for the reply. Personally I just use tagged unions and simple constructors to encode ADT in TypeScript because it lets to check such unions exhaustively, sort of exhaustive pattern matching. But I'll check your suggestion, thanks!
There was a problem hiding this comment.
@paldepind Looks like it's impossible to declare Cons using abstract class, because it would require declaring value and tail fields on Nil with some "nully" values to make shared generator work. That would defeat the very purpose of this PR - get rid of such values.
Declaring Cons using tagged union OTOH allows to declare value and tail only when isNil === false (means using isNil as tag).
|
Also I don't get why |
raveclassic
force-pushed
the
strict-null-checks
branch
from
7ab076d
to
009c49e
Compare
|
Does it make sense to continue on this? Is the only reason it is not merged yet the 0.12% missing test coverage of the patch? In case, I suggest to append this commit, covering some additional lines: DSoko2@163328b |
Hi, this PR is a continuation of #76 (fully includes that changes, so #76 should be merged first). This PR enables TS strictNullChecks flag and contains corresponding changes.
There're no breaking changes.