New component function, refactor TodoMVC #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
new-component-function
branch
from
bc7f7e4
to
91c07a7
Compare
paldepind
changed the title
limemloh
reviewed
Aug 22, 2019
| props?: { | ||
| [name: string]: Showable | Behavior<Showable | boolean>; | ||
| }; | ||
| props?: Attributes; |
There was a problem hiding this comment.
This is not the same, since attributes are HTML attributes and not the properties on the DOMElement.
Since an attribute could be set in the HTML without any value, we need the boolean, however this is not the case for properties on the DOMElement.
There was a problem hiding this comment.
Ah, I didn't notice that changing it added boolean to props. But, I've looked it up the documentation here and there are actually a couple of boolean-valued properties: spellcheck, translate, draggable, hidden, and more. So maybe this change is actually ok after all?
limemloh
reviewed
Aug 22, 2019
| const valueB: any = b[key]; | ||
| if (valueA !== undefined) { | ||
| if (isStream(valueA) && isStream(valueB)) { | ||
| (a as any)[key] = valueA.combine(valueB); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
looptocomponentand makes it handle a return value that allows setting the available output of the resulting component.Updates the TodoMVC example to use
componentinstead ofmodelViewand refactors it to follow other, IMHO, best practices.More than 100 lines of code shaved off in the TodoMVC.