Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a few new sources #8

Merged
merged 5 commits into from
Oct 12, 2018
Merged

add a few new sources #8

merged 5 commits into from
Oct 12, 2018

Conversation

Funnel-Mikael
Copy link

No description provided.

Copy link
Member

@dessibelle dessibelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing "Mats Dev" stuff.

Maybe consider rebasing 9155b150a406f6697d7ad73f27c99a6123bc7ee4 so they don't end up in the public google repo?

@@ -0,0 +1,6 @@
{
"id": "",
"name": "Mats Dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have this even in our forked repo. Not completed yet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also odd filename now that I think about it. Script fail?

sources.json Outdated
{
"id": "",
"name": "Mats Dev",
"categories": ["ADVERTISING"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes those should not be there not sure why they are there since i thought i didn't add them.

@dessibelle
Copy link
Member

I rebased in order to keep Mats' personal details out of the history in the public GDS repo :)

@dessibelle dessibelle merged commit d23b011 into master Oct 12, 2018
@dessibelle dessibelle deleted the new-contribution branch October 15, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants