Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

让Session继承net.Conn #58

Closed
wants to merge 3 commits into from
Closed

让Session继承net.Conn #58

wants to merge 3 commits into from

Conversation

zwczou
Copy link

@zwczou zwczou commented Jun 30, 2017

可以实现设置Read/Write Deadline,获取RemoteAddr, LocalAddr等

@codecov-io
Copy link

codecov-io commented Jul 1, 2017

Codecov Report

Merging #58 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   76.15%   76.24%   +0.09%     
==========================================
  Files           5        5              
  Lines         260      261       +1     
==========================================
+ Hits          198      199       +1     
  Misses         49       49              
  Partials       13       13
Impacted Files Coverage Δ
session.go 85.57% <100%> (+0.14%) ⬆️
server.go 82.14% <100%> (ø) ⬆️
manager.go 77.5% <100%> (ø) ⬆️
api.go 51.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3ad4f...623e9b9. Read the comment docs.

@patricksuo
Copy link

patricksuo commented Sep 29, 2017

现在的层级关系是 Session -> Codec 。 Codec 内部可能持有 net.Conn。

比如我们有用例就是 Session 里面是一个虚拟的连接,而不是 net.Conn

@zwczou zwczou closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants