Fix exit codes #139
Open
Fix exit codes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed keychain executions always return success exit code. The problem is that although keychain detects the failures and issues 'exit 1', in the actions of the 'trap' builtin used to cleanup some lock files upon exit, keychain masks the previous exit code by performing another 'exit 0'. To fix that, remove 'exit 0' from the trap actions to preserve the previous exit code of an internal exit invocation. Signed-off-by: Manolis Androulidakis <manolis@arrikto.com>
|
hello, @manolis-andr - first of all thank you for the PR and sorry that someone responded after ~4 months the reason why your PR didn't get any attention is that this is a mirror repository. Funtoo Linux contribution process happens via https://code.funtoo.org if you're still interested in contributing to Funtoo Linux you might be interested in this links: |
Jbigdaddylewis23
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed keychain executions always return success exit code. The problem
is that although keychain detects the failures and issues 'exit 1', in the
actions of the 'trap' builtin used to cleanup some lock files upon exit,
keychain masks the previous exit code by performing another 'exit 0'.
To fix that, remove 'exit 0' from the trap actions to preserve the
previous exit code of an internal exit invocation.