-
Notifications
You must be signed in to change notification settings - Fork 20
CLOSED: problem with js rendered fontawesome icons. #2
Comments
I'm not saying that this has to be fixed or something - just saying that there other ppl might have problem with this as well, but well it's just webpack particullary breaking alot scripts (like it took me few hours to setup tinymce with it); |
Now, information about the fontawesome package for upper bug:
My workaround:
Added for myself small change in:
|
Hello again, Thanks for your detailed feedback. Firstly the IconPicker is a simple plugin, and developed to get only FontAwesome icons class names easily, and add that on HTML forms. General purpose of the IconPicker is using it on websites admin panels or etc. And the form data can also be used on websites(front-end). A simple example of use is below. For Example:
Also if i can understand your purpose of use, may be i can help to develope it but i did not understand what's your expectations on that plugin :) Thank you. |
No, no it's fine - works as intended. Just saying that in some special case of fontawesome usage it breaks down. But I handled it with my custom json so it's all ok and does it's job - thanks. Hopefully there won't be any more suprises. :) |
So.
Generally I'm using webpack and most likely some fontawesome redesigned for it - not sure. Anyway, on beginning my icons looked like that:
Take a look that Your elements have tag: i.
Now I fixed my missing icons problem by adding js script attached to the fontawesome pack, but this is what happened:
So, how i partially fixed it.
div#IconPickerModal .ip-icons-content .ip-icons-search > i.placeholder-icon, div#IconPickerModal .ip-icons-content .ip-icons-search > svg.placeholder-icon {
However I'm just reverting this changes at my code, as this takes way to much time. Just wanted to let You know that there is such problem.
Meanwhile maybe I will find some other solution for my problem.
The text was updated successfully, but these errors were encountered: