Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

CLOSED: Does not work with font-awesome JS #3

Closed
petervanderwalt opened this issue Apr 17, 2020 · 2 comments
Closed

CLOSED: Does not work with font-awesome JS #3

petervanderwalt opened this issue Apr 17, 2020 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@petervanderwalt
Copy link

petervanderwalt commented Apr 17, 2020

If I use

<link rel="stylesheet" href="/lib/furcanIconPicker/dist/fontawesome-5.11.2/css/all.min.css">

it works (but I can't use CSS-only of font-awesome, we depend on some of the JS functionality

withoutjs

Font Awesome with JS says "When using our SVG framework, remember that Font Awesome-based <i> DOM elements are replaced with new <svg> elements by default. Be sure that your css rules target the right elements."

So when using it with JS instead

<script type="text/javascript" src="lib/fontawesome5/js/all.min.js"></script>

It fails (can't click icons, etc)

withjs

Therefore I beg of thee (: make plugin work with the JS version please (:

#2 relates too (same problem <i> replaced with <svg> elements by Font Awesome )

@petervanderwalt
Copy link
Author

Refer note at bottom of https://fontawesome.com/how-to-use/on-the-web/setup/getting-started among other documentation

@furcan
Copy link
Owner

furcan commented Apr 19, 2020

Hi,
Firstly thanks for using IconPicker.

This plugin did not design for using FontAwesome JS functionalities.

I noted this request and the next version of IconPicker may have this ability.

Thanks.

@furcan furcan closed this as completed Apr 19, 2020
@furcan furcan changed the title Does not work with font-awesome JS CLOSED: Does not work with font-awesome JS Apr 19, 2020
@furcan furcan added enhancement New feature or request question Further information is requested labels Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants