Picking API and picking tutorial #233
Conversation
|
Hello @Garyfallidis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-01 01:14:42 UTC |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 88.56% 88.36% -0.20%
==========================================
Files 18 19 +1
Lines 4469 4504 +35
Branches 571 580 +9
==========================================
+ Hits 3958 3980 +22
- Misses 367 372 +5
- Partials 144 152 +8
|
Garyfallidis
changed the title
|
Hi @Garyfallidis, When you finish with this PR, Can you rebase? it is hard to see your changes. Thanks! |
|
Yes of course. |
…re to engage multiple pickers at once
Garyfallidis
force-pushed
the
picking_api
branch
from
c3c8c05
to
0c65c32
Compare
Garyfallidis
changed the title
There was a problem hiding this comment.
Hi @Garyfallidis,
Really nice tutorial and useful functionality. See below some of my comments.
|
Addressed most of the comments. The only thing did not address is adding functionality for writing the buffers using pre-existing functions. This will need another PR and some extra thinking to do from what we offer here. |
There was a problem hiding this comment.
Hi @Garyfallidis,
Can you please address the 2 last comments below. We need to fix CI's error before merging this PR.
|
Thank you @Garyfallidis, CI's errors are not related so merging. |
This PR introduces a new class called
PickingManager.This class helps with getting information from actors in the 3D world.
You can receive vertex indices, face indices, world coordinate positions and actor ids.
Also very importantly this class shows how to directly access and update the vertices and colors of objects. Have in mind that there could be many objects in one actor.
@Nibba2018, @filipinascimento, @lenixlobo, @mlraglin, @nasimanousheh
This PR resolves issue #228