Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Animating primitives of the same actor #660

Draft
wants to merge 73 commits into
base: master
Choose a base branch
from

Conversation

m-agour
Copy link
Contributor

@m-agour m-agour commented Aug 15, 2022

Here are some examples (they are rather some approaches) on how to animate primitives of a single actor using multiple Timelines or a singe Timeline

The two examples are:
docs/tutorials/05_animation/viz_animating_billboard_spheres.py
docs/tutorials/05_animation/viz_animating_sub_primitives.py

anim.mp4

@pep8speaks
Copy link

pep8speaks commented Aug 15, 2022

Hello @m-agour! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 108:26: E127 continuation line over-indented for visual indent

Line 61:1: E265 block comment should start with '# '
Line 64:1: E265 block comment should start with '# '
Line 70:1: E265 block comment should start with '# '
Line 73:1: E265 block comment should start with '# '
Line 82:1: E265 block comment should start with '# '
Line 85:1: E265 block comment should start with '# '
Line 94:1: E265 block comment should start with '# '
Line 97:1: E265 block comment should start with '# '
Line 113:1: E122 continuation line missing indentation or outdented
Line 132:1: E265 block comment should start with '# '
Line 135:1: E265 block comment should start with '# '
Line 146:1: E122 continuation line missing indentation or outdented
Line 163:1: E122 continuation line missing indentation or outdented
Line 193:1: E265 block comment should start with '# '

Line 1079:17: E131 continuation line unaligned for hanging indent
Line 2816:41: E127 continuation line over-indented for visual indent

Comment last updated at 2022-08-19 15:56:28 UTC

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #660 (535f151) into master (db9771c) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   50.40%   50.29%   -0.11%     
==========================================
  Files         120      120              
  Lines       26830    26888      +58     
  Branches     2972     2978       +6     
==========================================
  Hits        13523    13523              
- Misses      12847    12903      +56     
- Partials      460      462       +2     
Impacted Files Coverage Δ
fury/actor.py 0.00% <0.00%> (ø)
fury/animation/timeline.py 0.00% <0.00%> (ø)
fury/fury/actor.py 86.28% <0.00%> (-2.27%) ⬇️
fury/fury/animation/timeline.py 57.75% <0.00%> (-0.14%) ⬇️

@skoudoro
Copy link
Contributor

Can you rebase this branch? or resolve the conflicts

Thanks

@Garyfallidis Garyfallidis changed the title Animating primitives of the same actor [WIP] Animating primitives of the same actor Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants