Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawPanel Update: Seperating tests to test individual features #674

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

ganimtron-10
Copy link
Contributor

As we are now adding new features to the DrawPanel the current test is becoming bigger and bigger.
Due to this creating, debugging, and managing tests is becoming harder.
So to keep things simple, separating tests to validate individual parts or features of the DrawPanel.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #674 (6730308) into master (6caaa03) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   50.40%   50.38%   -0.02%     
==========================================
  Files         120      120              
  Lines       26980    27014      +34     
  Branches     2986     2988       +2     
==========================================
+ Hits        13598    13610      +12     
- Misses      12923    12945      +22     
  Partials      459      459              
Impacted Files Coverage Δ
fury/ui/tests/test_elements.py 0.00% <0.00%> (ø)
fury/fury/ui/tests/test_elements.py 80.39% <0.00%> (-0.11%) ⬇️
fury/fury/ui/elements.py 90.11% <0.00%> (-0.07%) ⬇️

@skoudoro
Copy link
Contributor

skoudoro commented Sep 6, 2022

I do not see any issue. all the tests are running ok in my laptop so I am going ahead and merge this PR.

Thanks @ganimtron-10

@skoudoro skoudoro merged commit a8f1d76 into fury-gl:master Sep 6, 2022
@ganimtron-10 ganimtron-10 deleted the sep-drawpanel-test branch September 6, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants